Define program-wide Rust flags in .bazelrc #454
Conversation
fhanau
force-pushed
the
felix/rust-flags
branch
2 times, most recently
from
4360811
to
e778241
Compare
fhanau
changed the title
|
Do we want panics to be aborts? This differs significantly from our philosophy on the C++ side, where we use exceptions like panics, but we very much want to be able to catch them, so that we can fail out just one request instead of crashing the server. |
panic=abort is what we are currently using based on For fastdbg panic=unwind should be preferable either way, I'm also open to changing it in the general case |
|
Ah OK, makes sense. (I'm not competent to review this diff, will leave it to Mike.) |
fhanau
force-pushed
the
felix/rust-flags
branch
from
e778241
to
f953341
Compare
The flags defined so far in rust-deps/BUILD.bazel are not applied to dependent targets, so manually define global Rust flags to enable
-C panic=abortand improve code size. Linux opt binaries are ~280KB smaller as a result.I also considered a number of other configurations and identified some options that might be good for release builds, the comments describe how these might be used in a future release configuration.
Upstream PR has been added.